GH-38402: [CI][Integration] Provide wrapper scripts for integration testing #38403
+79
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
reviewed
Oct 23, 2023
github-actions
bot
added
awaiting changes
kou
reviewed
Oct 23, 2023
| @@ -20,11 +20,25 @@ | |||
| set -ex | |||
|
|
|||
| arrow_dir=${1} | |||
| build_dir=${2} | |||
There was a problem hiding this comment.
It seems that this isn't used. Do we need this?
github-actions
bot
added
awaiting change review
|
@kou Could you review this again? |
|
@tustvold Could you try this in apache/arrow-rs? |
tustvold
reviewed
Oct 25, 2023
| --with-csharp=$([ "$ARROW_INTEGRATION_CSHARP" == "ON" ] && echo "1" || echo "0") \ | ||
| --with-go=$([ "$ARROW_INTEGRATION_GO" == "ON" ] && echo "1" || echo "0") \ | ||
| --with-java=$([ "$ARROW_INTEGRATION_JAVA" == "ON" ] && echo "1" || echo "0") \ | ||
| --with-js=$([ "$ARROW_INTEGRATION_JS" == "ON" ] && echo "1" || echo "0") \ |
There was a problem hiding this comment.
I think we need a with-rust here in order to use this in arrow-rs
There was a problem hiding this comment.
There's no with-rust currently. The ARCHERY_INTEGRATION_WITH_RUST environment variable is used.
There was a problem hiding this comment.
We're currently using it - https://github.com/apache/arrow-rs/blob/master/.github/workflows/integration.yml#L121
I'll give the env variable a go as well
There was a problem hiding this comment.
Ahah... I don't know why we have both then.
github-actions
bot
added
awaiting changes
JerAguilon
pushed a commit
to JerAguilon/arrow
that referenced
this pull request
Oct 25, 2023
…tion testing (apache#38403) ### Rationale for this change It is currently cumbersome to run integration tests from an other repository, as each tested implementation must be built explicitly. See explanatory comment at apache/arrow-rs#4957 (comment) ### What changes are included in this PR? Provide a wrapper script to automate building the implementations being tested. Allow usage of environment variables such as `ARROW_INTEGRATION_CPP`, etc. to selectively disable implementations. ### Are these changes tested? Yes, by construction. ### Are there any user-facing changes? No. * Closes: apache#38402 Authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 99f893f. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them. |
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…tion testing (apache#38403) ### Rationale for this change It is currently cumbersome to run integration tests from an other repository, as each tested implementation must be built explicitly. See explanatory comment at apache/arrow-rs#4957 (comment) ### What changes are included in this PR? Provide a wrapper script to automate building the implementations being tested. Allow usage of environment variables such as `ARROW_INTEGRATION_CPP`, etc. to selectively disable implementations. ### Are these changes tested? Yes, by construction. ### Are there any user-facing changes? No. * Closes: apache#38402 Authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…tion testing (apache#38403) ### Rationale for this change It is currently cumbersome to run integration tests from an other repository, as each tested implementation must be built explicitly. See explanatory comment at apache/arrow-rs#4957 (comment) ### What changes are included in this PR? Provide a wrapper script to automate building the implementations being tested. Allow usage of environment variables such as `ARROW_INTEGRATION_CPP`, etc. to selectively disable implementations. ### Are these changes tested? Yes, by construction. ### Are there any user-facing changes? No. * Closes: apache#38402 Authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
It is currently cumbersome to run integration tests from an other repository, as each tested implementation must be built explicitly.
See explanatory comment at apache/arrow-rs#4957 (comment)
What changes are included in this PR?
Provide a wrapper script to automate building the implementations being tested.
Allow usage of environment variables such as
ARROW_INTEGRATION_CPP, etc. to selectively disable implementations.Are these changes tested?
Yes, by construction.
Are there any user-facing changes?
No.